[MRG] skip dataset downloading doctest #11284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Jun 15, 2018
doc/conftest.py
Outdated
| @@ -47,12 +47,14 @@ def setup_rcv1(): | |||
|
|
|||
| def setup_twenty_newsgroups(): | |||
| data_home = get_data_home() | |||
| if not exists(join(data_home, '20news_home')): | |||
| if not exists(join(data_home, "20news-bydate_py3.pkz")): | |||
There was a problem hiding this comment.
is this python3 specific? Maybe the easiest way would be to try and load it and catch the except?
There was a problem hiding this comment.
Changed to use the pickle filepath specific to the python version of the test runner.
74bf243 to
f6cf3d0
Compare
|
looks good, let's see what travis says |
|
Thanks @amueller, @ehashman, and @tsopenlin for the help! |
georgipeev
pushed a commit
to georgipeev/scikit-learn
that referenced
this pull request
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #4732
What does this implement/fix? Explain your changes.
Skips downloading the 20news dataset for the
working_with_text_data.rstdoctest.