8000 [MRG] [RFC] multiclass and types_of_target by massich · Pull Request #11213 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] [RFC] multiclass and types_of_target #11213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

[MRG] [RFC] multiclass and types_of_target #11213

wants to merge 17 commits into from

Conversation

massich
Copy link
Contributor
@massich massich commented Jun 6, 2018

Reference Issues/PRs

fixes #9777

What does this implement/fix? Explain your changes.

Any other comments?

This PR should be entered before #9059

@massich massich changed the title [WIP] [WIP] multiclass and types_of_target Jun 6, 2018
@massich massich force-pushed the multiclass_type_of_target branch from 1a73583 to cb57d0a Compare July 10, 2018 03:28
@massich
Copy link
Contributor Author
massich commented Jul 10, 2018

Do you think that this is understandable?
https://27139-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html

@massich massich force-pushed the multiclass_type_of_target branch from cb57d0a to b2d9563 Compare July 10, 2018 22:42
@jnothman
Copy link
Member

It looks reasonable, but a lot of the information is redundant with the glossary section on target types. So perhaps it makes more sense to refer the reader there for details on formats and APIs.

@jnothman
Copy link
Member

To refer to the glossary, you should use the term role, e.g. :term:`multiclass`

@massich massich force-pushed the multiclass_type_of_target branch from efb307b to 15da70a Compare July 16, 2018 03:24
@massich massich changed the title [WIP] multiclass and types_of_target [MRG] multiclass and types_of_target Jul 16, 2018
@massich massich changed the title [MRG] multiclass and types_of_target [RFC] multiclass and types_of_target Jul 16, 2018
@massich
Copy link
Contributor Author
massich commented Jul 16, 2018 •
edited
Loading

in a conversation at scipy2018, @ivanov suggested that maybe the problem for rewording the multiclass was that the examples were not the 'same' for all the scenarios.

So here's a draft. I'm not really sure that all the examples make sense or are clear enough. So, comments are welcome!!

If anyone can think of a different set of coherent examples, don't be shy.

here's the artifact https://27909-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html

@massich massich changed the title [RFC] multiclass and types_of_target [MRG] [RFC] multiclass and types_of_target Jul 16, 2018
@glemaitre
Copy link
Member

IMO, I find that the changes make the documentation hard to read (too much level of bullet points)

@massich massich force-pushed the multiclass_type_of_target branch from 15da70a to b17598a Compare July 20, 2018 17:19
@massich
Copy link
Contributor Author
massich commented Sep 6, 2019

@lucyleeow can you give it a read? and we finish it

@massich
Copy link
Contributor Author
massich commented Sep 6, 2019

This is the current master https://scikit-learn.org/stable/modules/multiclass.html

< 8000 div class="AvatarStack-body" >
[emtpy] trigger circle
2e03d7a
@massich
Copy link
Contributor Author
massich commented Sep 6, 2019

here is the last version https://29571-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html

massich
massich commented Sep 6, 2019
View reviewed changes
doc/modules/multiclass.rst
for each data-point, such as wind direction and magnitude at a
certain location.
- valid :term:`multiclass` representation for
:func:`~utils.multiclass.type_of_target` (`y`) are:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be clickable and point to https://scikit-learn.org/stable/modules/generated/sklearn.utils.multiclass.type_of_target.html#sklearn.utils.multiclass.type_of_target

@massich massich mentioned this pull request Sep 11, 2019
Closed
@lucyleeow
Copy link
Member
lucyleeow commented Sep 11, 2019 •
edited
Loading

@massich it's still failing - but this may be because master is broken?

@rth
Copy link
Member
rth commented Sep 11, 2019

Yes, CI still fails on master cf #14956 (comment) . We need to investigate it.

@lucyleeow lucyleeow mentioned this pull request Oct 22, 2019
Merged
@massich
Copy link
Contributor Author
massich commented Oct 22, 2019 •
edited
Loading

Closing in favor of #15333 since @lucyleeow did a great job!

@massich massich closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calling type_of_target crashes before returning unknown
6 participants
@massich @jnothman @glemaitre @lucyleeow @rth @amueller
0