[MRG] add whats_new entry for KMeans sample weight support #11119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
May 22, 2018
| @@ -611,3 +614,8 @@ Changes to estimator checks | |||
| - Add tests in :func:`estimator_checks.check_estimator` to check that an | |||
| estimator can handle read-only memmap input data. :issue:`10663` by | |||
| :user:`Arthur Mensch <arthurmensch>` and :user:`Loïc Estève <lesteve>`. | |||
|
|
|||
| - :func:`estimator_checks.check_sample_weights_pandas_series` now uses 8 rather | |||
There was a problem hiding this comment.
not sure we usually document utils but I guess there's no harm in documenting this.
There was a problem hiding this comment.
I agree this is not a very interesting change, but given that there was a dedicated section for changes to estimator checks already I added it
amueller
reviewed
May 22, 2018
doc/whats_new/v0.20.rst
Outdated
| @@ -111,6 +111,9 @@ Decomposition, manifold learning and clustering | |||
| - :class:`cluster.AgglomerativeClustering` now supports Single Linkage | |||
| clustering via ``linkage='single'``. :issue:`9372` by | |||
| :user:`Leland McInnes <lmcinnes>` and :user:`Steve Astels <sastels>`. | |||
| - :class:`cluster.KMeans` and :class:`cluster.MiniBatchKMeans` now support | |||
|
Thanks @jnhansen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #10933.
What does this implement/fix? Explain your changes.
Adding entry in
doc/whats_new/v0.20.rstfor added sample weight support incluster.KMeans.