8000 [MRG] Use imgconverter sphinx extension for SVG support in latex by lesteve · Pull Request #11106 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Use imgconverter sphinx extension for SVG support in latex #11106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2018
Merged

[MRG] Use imgconverter sphinx extension for SVG support in latex #11106

merged 1 commit into from
May 18, 2018

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented May 18, 2018

And use SVG afpy logo in about.rst.

Should fix #11089. I tested it locally but there is no good way of knowing before merging into master where the make latexpdf will be run.

@lesteve lesteve mentioned this pull request May 18, 2018
Closed
rth
rth approved these changes May 18, 2018
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If locally this works it should be fine. (I could reproduce the error locally). Thanks!

doc/about.rst
@@ -220,7 +220,7 @@ The 2013 Paris international sprint
:target: https://www.tinyclues.com/


.. |afpy| image:: https://www.afpy.org/logo.png
.. |afpy| image:: https://www.afpy.org/static/images/logo.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aww, great, I couldn't find the right path to the svg logo..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it thanks to you and the issue you submitted to afpy :-).

qinhanmin2014
qinhanmin2014 approved these changes May 18, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the Circle error (HTTPError for fetch_mldata) is irrelevant.

@qinhanmin2014 qinhanmin2014 merged commit 873c801 into scikit-learn:master May 18, 2018
@rth rth mentioned this pull request May 18, 2018
Closed
@lesteve lesteve deleted the fix-afpy-logo branch May 18, 2018 11:26
ogrisel pushed a commit that referenced this pull request Jul 15, 2018
@lesteve @ogrisel
MNT Use imgconverter sphinx extension for SVG support in latex. (#11106)
622c2d3
@TomDLT TomDLT mentioned this pull request Aug 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circle CI and Appveyor fails on master
3 participants
@lesteve @rth @qinhanmin2014
0