8000 Fix plot tomography l1 reconstruction by lesteve · Pull Request #11100 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Fix plot tomography l1 reconstruction #11100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2018
Merged

Fix plot tomography l1 reconstruction #11100

merged 2 commits into from
May 16, 2018

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented May 16, 2018 •
edited
Loading

Fix part of #11089.

Here is the plot from the dev doc for comparison:

rth and others added 2 commits May 13, 2018 10:07
@rth
Ensure that the number of angles is integer
590cbac
@lesteve
Fix plot_tomography_l1_reconstruction.py
a600884 
Error was: TypeError: 'numpy.float64' object cannot be interpreted as an integer.

[doc build]
@lesteve lesteve mentioned this pull request May 16, 2018
Closed
@sklearn-lgtm
Copy link

This pull request fixes 1 alert when merging a600884 into 48f3303 - view on lgtm.com

fixed alerts:

  • 1 for Result of integer division may be truncated

Comment posted by lgtm.com

rth
rth approved these changes May 16, 2018
View reviewed changes
Copy link
Member
@rth rth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it @lesteve !

Well, Circle CI is still failing now with "HTTP Error 500" when running fetch_mldata('mauna-loa-atmospheric-co2') (if I read the log correctly), but this does fix the original issue.

Restarted Circle CI..

@rth
Copy link
Member
rth commented May 16, 2018

Restarting Circle CI fixed the download failure; also checked that the rendered example image is identical to the one in the stable documentation.

@jnothman jnothman merged commit 1557cb8 into scikit-learn:master May 16, 2018
@rth rth mentioned this pull request May 18, 2018
Closed
@qinhanmin2014 qinhanmin2014 mentioned this pull request Jul 5, 2018
Merged
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 5, 2018
@lesteve @jnothman
EXA Fix plot tomography l1 reconstruction (scikit-learn#11100)
0a748af 
* Ensure that the number of angles is integer

* Fix plot_tomography_l1_reconstruction.py
7903


Error was: TypeError: 'numpy.float64' object cannot be interpreted as an integer.

[doc build]
@lesteve lesteve deleted the fix-plot_tomography_l1_reconstruction branch February 9, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesteve @sklearn-lgtm @rth @jnothman
0