[WIP] Avoid float64 conversion for float32 in transformers #11004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
Apr 21, 2018
sklearn/utils/estimator_checks.py
Outdated
| 'PLSCanonical', 'PLSRegression', 'PLSSVD', 'RBFSampler', | ||
| 'RandomizedLasso', 'RandomizedLogisticRegression', 'SelectFdr', | ||
| 'SelectFpr', 'SelectFwe', 'SelectKBest', 'SkewedChi2Sampler', | ||
| 'SparsePCA', 'SparseRandomProjection', 'VarianceThreshold'] |
There was a problem hiding this comment.
We also need to include BadTransformerWithoutMixin here and remove the PLS related estimators.
9f4ab2e to
daf06b3
Compare
added 2 commits
April 21, 2018 19:15
74bb95c to
e9ea2d1
Compare
43160cf to
22eedc1
Compare
239ee75 to
4f209ed
Compare
6902996 to
6bf9e85
Compare
|
CCA inherits from _PLS, so needs to be removed from list as it has the same issues with the _PLS |
def48d3 to
aecae5f
Compare
4850707 to
0ff938f
Compare
|
This pull request introduces 3 alerts when merging 508d95e into 7124d87 - view on lgtm.com new alerts:
Comment posted by lgtm.com |
|
This pull request introduces 3 alerts when merging 1df891a into 96a02f3 - view on lgtm.com new alerts:
Comment posted by lgtm.com |
|
@Mariand012 are you still working on this? |
|
Closing since many of the transformers touched in this PR now preserves dtypes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
related to #11000
What does this implement/fix? Explain your changes.
Avoid conversion float 64 in PLS
Any other comments?