[WIP] Added deprecation warnings for min_impurity_split #10174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Doc, replacing "the scikit" with "scikit-learn"
Adding DeprecationWarning for min_impurity_split in forest.py and gradient_boosting
|
This doesn't seem related to #10158. The issue I raised was about catching these warnings when raised by the tests. |
|
hmm I see ... I'll examine the tests then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10158
What does this implement/fix? Explain your changes.
Added deprecation warnings for min_impurity_split in constructor.
The warning message used is the one in tree.py
scikit-learn/sklearn/tree/tree.py
Lines 279 to 282 in e2584c3
Any other comments?
These are the files I found appropriate for adding min_impurity_split deprecation warnings.