[MRG] DOC add documentation about Travis cron job #10124
Conversation
doc/developers/maintainer.rst
Outdated
| related to a numpy change and not a scikit-learn one, so it would not make sense | ||
| to blame the PR author for the Travis failure. | ||
|
|
||
| The definition of what's get run in the Cron job is done in the .travis.yml, |
doc/developers/maintainer.rst
Outdated
| to blame the PR author for the Travis failure. | ||
|
|
||
| The definition of what's get run in the Cron job is done in the .travis.yml, | ||
| exactly the same way as the other Travis job. We use a ``if: type = cron`` |
There was a problem hiding this comment.
There's a link at the top:
For more information see https://github.com/scikit-learn/scikit-learn/wiki/How-to-make-a-release
Since we now have two sections, will it be more reasonable to move it into the first section (Making a release)?
| = cron`` filter in order for the build to be run only in Cron jobs. | ||
|
|
||
| The branch targetted by the Cron job and the frequency of the Cron job is set | ||
| via the web UI at https://www.travis-ci.org/scikit-learn/scikit-learn/settings. |
There was a problem hiding this comment.
Not sure but I might add something like "Currently, we run Cron job daily for master branch."
There was a problem hiding this comment.
I tried to avoid "This is what we do currently" kind of information because in my experience they can become irrelevant/misleading reasonably quickly. Also in this case I think it is reasonably clear from https://www.travis-ci.org/scikit-learn/scikit-learn/settings which branch we run the Cron jobs on.
There was a problem hiding this comment.
Thanks for the reply. I think you are right :)
|
This doesn't really belong to making a release. It's about managing continuous integration, not release. |
|
@jnothman My suggestion is to move the link below the title inside the 'making a release' section because we now have two sections. Previously, we only have one section here. |
|
Good catch @qinhanmin2014 I moved the wiki link to the "Make a release" section. |
Codecov Report
@@ Coverage Diff @@
## master #10124 +/- ##
=======================================
Coverage 96.2% 96.2%
=======================================
Files 337 337
Lines 62817 62817
=======================================
Hits 60432 60432
Misses 2385 2385Continue to review full report at Codecov.
|
|
Two approvals -> merge. |
As @amueller kindly requested in #10074 (comment).