8000 more descriptive assignment in Working With Text Data documentation · Issue #8285 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

more descriptive assignment in Working With Text Data documentation #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seanpwilliams opened this issue Feb 3, 2017 · 1 comment · Fixed by #8314
Closed

more descriptive assignment in Working With Text Data documentation #8285

seanpwilliams opened this issue Feb 3, 2017 · 1 comment · Fixed by #8314

Comments

@seanpwilliams
Copy link
Contributor

Description

In the Evaluation of Performance on the Test Set section, text_clf.fit(twenty_train.data, twenty_train.target) for an SVM is assigned simply as _ while the assignment for the Naive Bayes classifier above is assigned as text_clf.

http://scikit-learn.org/stable/tutorial/text_analytics/working_with_text_data.html#evaluation-of-the-performance-on-the-test-set
@lesteve
Copy link
Member
lesteve commented Feb 7, 2017

PR welcome! I would be in favour of removing the assignment since they are not useful at all, so replacing:

text_clf = text_clf.fit(twenty_train.data, twenty_train.target)

by:

text_clf.fit(twenty_train.data, twenty_train.target)

and:

_ = text_clf.fit(twenty_train.data, twenty_train.target)

by:

text_clf.fit(twenty_train.data, twenty_train.target)

@seanpwilliams seanpwilliams mentioned this issue Feb 8, 2017
Merged
jnothman pushed a commit that referenced this issue Feb 8, 2017
@seanpwilliams @jnothman
DOC: Remove superfluous assignment in tutorial. issue #8285 (#8314)
bae38a2 
* remove assignment

per recommendation

* Fix doctests
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this issue Feb 28, 2017
@seanpwilliams @sergeyf
DOC: Remove superfluous assignment in tutorial. issue scikit-learn#8285…
0e70e6a 
… (scikit-learn#8314)

* remove assignment

per recommendation

* Fix doctests
@Przemo10 Przemo10 mentioned this issue Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@seanpwilliams @Sundrique
DOC: Remove superfluous assignment in tutorial. issue scikit-learn#8285…
357d4d3 
… (scikit-learn#8314)

* remove assignment

per recommendation

* Fix doctests
NelleV pushed a commit to NelleV/scikit-learn that referenced this issue Aug 11, 2017
@seanpwilliams @NelleV
DOC: Remove superfluous assignment in tutorial. issue scikit-learn#8285…
5184a8d 
… (scikit-learn#8314)

* remove assignment

per recommendation

* Fix doctests
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@seanpwilliams @paulha
DOC: Remove superfluous assignment in tutorial. issue scikit-learn#8285…
002184f 
… (scikit-learn#8314)

* remove assignment

per recommendation

* Fix doctests
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017
@seanpwilliams @maskani-moh
DOC: Remove superfluous assignment in tutorial. issue scikit-learn#8285…
9eb3263 
… (scikit-learn#8314)

* remove assignment

per recommendation

* Fix doctests
lemonlaug pushed a commit to lemonlaug/scikit-learn that referenced this issue Jan 6, 2021
@seanpwilliams
DOC: Remove superfluous assignment in tutorial. issue scikit-learn#8285…
695676f 
… (scikit-learn#8314)

* remove assignment

per recommendation

* Fix doctests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC: Remove superfluous assignment in tutorial. issue #8285 seanpwilliams/scikit-learn
2 participants
@lesteve @seanpwilliams
0