8000 rng attribute is set in sklearn.gaussian_process.GaussianProcessRegressor at fit time · Issue #7752 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
8000

rng attribute is set in sklearn.gaussian_process.GaussianProcessRegressor at fit time #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MechCoder opened this issue Oct 25, 2016 · 11 comments
Closed

rng attribute is set in sklearn.gaussian_process.GaussianProcessRegressor at fit time #7752

MechCoder opened this issue Oct 25, 2016 · 11 comments
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted

Comments

@MechCoder
Copy link
Member

See https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/gaussian_process/gpr.py#L164
@MechCoder MechCoder added the Easy Well-defined and straightforward way to resolve label Oct 25, 2016
@amueller
Copy link
Member

It should be rng_

@amueller
Copy link
Member

And after #7553 is merged, we should make sure that everything that's added in fit has a trailing underscore or is private.

@amueller
Copy link
Member

@MechCoder you should use the NeedContributor tag, it really helps people find issues, I think.

@MechCoder
Copy link
Member Author

Sure, will do that:) and I'm not sure we need to make it an attribute.

@amueller
Copy link
Member

ok maybe it's better not to.

@tayyabpw tayyabpw mentioned this issue Oct 27, 2016
Closed
@tomron
Copy link
tomron commented Nov 30, 2016

I'll do that

tomron added a commit to tomron/scikit-learn that referenced this issue Nov 30, 2016
@tomron
scikit-learn#7752 self.rng to private -> self.rng_
133e945
tomron added a commit to tomron/scikit-learn that referenced this issue Nov 30, 2016
@tomron
scikit-learn#7752 self.rng to private -> self.rng_
7bcd076
@jnothman
Copy link
Member
jnothman commented Nov 30, 2016 via email

@amanp10
Copy link
Contributor
amanp10 commented Dec 5, 2016

Hello,
I am new to scikit-learn. Can I work on this issue?

@amueller
Copy link
Member
amueller commented Dec 5, 2016

@amanp10 there's a PR at #7766 as you can see above.

@dalmia dalmia mentioned this issue Dec 8, 2016
Closed
@amueller amueller mentioned this issue Dec 8, 2016
Merged
@amueller amueller added good first issue Easy with clear instructions to resolve help wanted labels Aug 21, 2018
@btel
Copy link
Contributor
btel commented Feb 25, 2019

this seems solved:

 self._rng = check_random_state(self.random_state)

https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/gaussian_process/gpr.py#L183

@agramfort
Copy link
Member

true. Closing. Thx @btel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted
Projects
None yet
Milestone
No milestone
7 participants
@btel @jnothman @agramfort @amueller @MechCoder @tomron @amanp10
0