8000 Gaussian process uses string comparison on arrays · Issue #5663 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Gaussian process uses string comparison on arrays #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Nov 2, 2015 · 2 comments
Closed

Gaussian process uses string comparison on arrays #5663

amueller opened this issue Nov 2, 2015 · 2 comments
Labels
Easy Well-defined and straightforward way to resolve

Comments

@amueller
Copy link
Member
amueller commented Nov 2, 2015

The new GP raises a lot of "FutureWarning: elementwise comparison failed" in the tests.
This should be avoided by checking if the parameter is a string, as done here:
https://github.com/scikit-learn/scikit-learn/pull/5413/files#diff-a84a355d447d21d71c4f82afbeba65edR647
@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Nov 2, 2015
ziky90 added a commit to ziky90/scikit-learn that referenced this issue Nov 3, 2015
@ziky90
Fixed string comparison on arrays in new Gaussian process described i…
149aade 
…n issue scikit-learn#5663
@ziky90 ziky90 mentioned this issue Nov 3, 2015
Merged
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this issue Feb 13, 2016
@ziky90
Fixed string comparison on arrays in new Gaussian process described i…
ffa8fd8 
…n issue scikit-learn#5663
mannby pushed a commit to mannby/scikit-learn that referenced this issue Apr 22, 2016
@ziky90
Fixed string comparison on arrays in new Gaussian process described i…
82855f0 
…n issue scikit-learn#5663
@dhanus
Copy link
Contributor
dhanus commented Jul 16, 2016

@amueller @TomDLT I think this issue can be closed.

@amueller
Copy link
Member Author

@dhanus thanks :)

TomDLT pushed a commit to TomDLT/scikit-learn that referenced this issue Oct 3, 2016
@ziky90 @TomDLT
Fixed string comparison on arrays in new Gaussian process described i…
fc53cd3 
…n issue scikit-learn#5663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amueller @dhanus @TomDLT
0