8000 fetch_mldata doctests will fail with no internet connection · Issue #358 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

fetch_mldata doctests will fail with no internet connection #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabianp opened this issue Sep 21, 2011 · 3 comments
Closed

fetch_mldata doctests will fail with no internet connection #358

fabianp opened this issue Sep 21, 2011 · 3 comments
Milestone
0.11

Comments

@fabianp
Copy link
Member
fabianp commented Sep 21, 2011

The doctests in function datasets.fetch_mldata will fail if there is no internet connection and data is not already stored in disk
fabianp pushed a commit that referenced this issue Sep 21, 2011
Comment out doctest for fetch_mldata
3f1ea66 
See issue #358:

    #358
@ogrisel
Copy link
Member
ogrisel commented Sep 22, 2011

we should devise an API to tests whether a remote dataset has already been fetched or not and use it as condition to execute the test or not.

@fabianp
Copy link
Member Author
fabianp commented Dec 5, 2011

I would simply replace the docstrings for that function with reference to examples.

@fabianp fabianp mentioned this issue Jan 9, 2012
Closed
@GaelVaroquaux
Copy link
Member

I think that the solution that @fabianp used in 3f1ea66 is OK: anything better will require much more work for little gain. I am closing this issue. If people disagree, they should feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
3 participants
@ogrisel @GaelVaroquaux @fabianp
0