10000 ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil ⚠️ · Issue #25095 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

⚠️ CI failed on Linux_nogil.pylatest_pip_nogil ⚠️ #25095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scikit-learn-bot opened this issue Dec 2, 2022 · 2 comments · Fixed by #25098
Closed

⚠️ CI failed on Linux_nogil.pylatest_pip_nogil ⚠️ #25095

scikit-learn-bot opened this issue Dec 2, 2022 · 2 comments · Fixed by #25098
Labels
Bug Build / CI

Comments

@scikit-learn-bot
Copy link
Contributor

CI failed on Linux_nogil.pylatest_pip_nogil (Dec 02, 2022)

  • test_balance_property[74-False-LogisticRegressionCV]
@github-actions github-actions bot added the Needs Triage Issue requires triage label Dec 2, 2022
@ogrisel
Copy link
Member
ogrisel commented Dec 2, 2022 •
edited
Loading

This might not be related to nogil but rather to global_random_seed=74. The assertion failure is barely above the tolerance level (0.35003600108334504 == 0.35 ± 3.5e-05).

@ogrisel
Copy link
Member
ogrisel commented Dec 2, 2022

I can reproduce on my macos laptop with:

SKLEARN_TESTS_GLOBAL_RANDOM_SEED=74 pytest -k"test_balance_property[74-False-LogisticRegressionCV]" sklearn/linear_model/tests/test_common.py

so it's independent of the platform and version of Python. I will open a PR to adjust the tolerance and make the test robust to the choice of the seed.

ogrisel added a commit to ogrisel/scikit-learn that referenced this issue Dec 2, 2022
@ogrisel
MAINT adjust tolerance in test_balance_property
c14545c 
Fixes scikit-learn#25095 to make the test pass with:

  SKLEARN_TESTS_GLOBAL_RANDOM_SEED=74

for LogisticRegressionCV.
@ogrisel ogrisel mentioned this issue Dec 2, 2022
Merged
@ogrisel ogrisel added Bug Build / CI and removed Needs Triage Issue requires triage labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT adjust tolerance in test_balance_property ogrisel/scikit-learn
2 participants
@ogrisel @scikit-learn-bot
0