8000 mismatch between scoring and function for AUC · Issue #2096 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

mismatch between scoring and function for AUC #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mblondel opened this issue Jun 25, 2013 · 11 comments
Closed

mismatch between scoring and function for AUC #2096

mblondel opened this issue Jun 25, 2013 · 11 comments
Milestone
0.14

Comments

@mblondel
Copy link
Member

The argument to be passed to the scoring parameter of GridSearchCV for AUC is "roc_auc" although the metric is called "auc_score", not "roc_auc_score".

I know that using AUC alone can be ambiguous but most people use the name to refer to the one under the ROC curve (as opposed to the one under the precision-recall curve).

I'd suggest to create an alias, unless we want to rename "auc_score" to "roc_auc_score"?
@arjoly
Copy link
Member
arjoly commented Jul 25, 2013

There is also mse and ari.

@amueller
Copy link
Member

@arjoly you fixed mse and ari, right?
Someone told me explicitly to call this roc_auc. I would also say that it is not really ambiguous. Renaming aus_score to roc_auc_score seems a bit weird to me.

@arjoly
Copy link
Member
arjoly commented Jul 26, 2013

@arjoly you fixed mse and ari, right?

Yes

Someone told me explicitly to call this roc_auc. I would also say that it is not really ambiguous. Renaming aus_score to roc_auc_score seems a bit weird to me.

I don't have any opinions on these except that roc_auc_score seems to be the most explicit.

@amueller
Copy link
Member

well, if you don't know what auc is, will you know what roc auc is?
Anyhow, I don't have a strong opinion and if any one else says roc_auc_score it's fine with me.

@arjoly
Copy link
Member
arjoly commented Jul 26, 2013

then roc_score seems a better option.

@amueller
Copy link
Member

this needs still be fixed, right?

@arjoly
Copy link
Member
arjoly commented Jul 27, 2013

As far as I know, yes.

@GaelVaroquaux
Copy link
Member

Is this a regression in 0.14 compared to 0.13 or not?

@arjoly
Copy link
Member
arjoly commented Jul 28, 2013

What do you mean by regression?

@amueller
Copy link
Member

the scoring did not exist before. it was introduced with an inconsistent name

@GaelVaroquaux
Copy link
Member

People, can we fix this in a couple of days? I don't want to weigh in, as I feel that others have a better view of the problem.
8000

@arjoly arjoly mentioned this issue Aug 7, 2013
Merged
@arjoly arjoly closed this as completed in cf73a9e Aug 7, 2013
arjoly added a commit that referenced this issue Aug 7, 2013
@arjoly @ogrisel
ENH more explicit name for auc + consistency for scorer, fix #2096
1f0815b 
Conflicts:
	sklearn/metrics/tests/test_metrics.py
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this issue Aug 22, 2013
@yarikoptic
Merge tag '0.14' into releases
934108b 
0.14 release

* tag '0.14': (46 commits)
  REL: 0.14 release: update whats_new and version
  MAINT Update mailmap
  DOC: fix CSS bug
  DOC: update documentation for release
  MISC: deprection is in 2 releases
  MAINT: randn on float is deprecated
  TST: avoid nose running sklearn.test as a test
  MISC: fix wrong timing in example
  FIX integer types in Ward clustering
  TST: avoid a crash in Windows + Anaconda Py3.3
  FIX search and replace misstake
  DOC put the narrative documentation of roc_curve and roc_auc_score in one place
  ENH more explicit name for auc + consistency for scorer, fix scikit-learn#2096
  DOC: button layout tweak
  Website: bottom buttons
  DOC: bigger menu fonts
  DOC: layout tweaks
  Polishing on "Who's using scikit-learn"
  FIX typo in testimonials
  ENH testimonials img are now centered.
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this issue Aug 22, 2013
@yarikoptic
Merge branch 'releases' into dfsg
608cd63 
* releases: (46 commits)
  REL: 0.14 release: update whats_new and version
  MAINT Update mailmap
  DOC: fix CSS bug
  DOC: update documentation for release
  MISC: deprection is in 2 releases
  MAINT: randn on float is deprecated
  TST: avoid nose running sklearn.test as a test
  MISC: fix wrong timing in example
  FIX integer types in Ward clustering
  TST: avoid a crash in Windows + Anaconda Py3.3
  FIX search and replace misstake
  DOC put the narrative documentation of roc_curve and roc_auc_score in one place
  ENH more explicit name for auc + consistency for scorer, fix scikit-learn#2096
  DOC: button layout tweak
  Website: bottom buttons
  DOC: bigger menu fonts
  DOC: layout tweaks
  Polishing on "Who's using scikit-learn"
  FIX typo in testimonials
  ENH testimonials img are now centered.
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this issue Aug 22, 2013
@yarikoptic
Merge branch 'dfsg' into debian
631b7c8 
* dfsg: (46 commits)
  REL: 0.14 release: update whats_new and version
  MAINT Update mailmap
  DOC: fix CSS bug
  DOC: update documentation for release
  MISC: deprection is in 2 releases
  MAINT: randn on float is deprecated
  TST: avoid nose running sklearn.test as a test
  MISC: fix wrong timing in example
  FIX integer types in Ward clustering
  TST: avoid a crash in Windows + Anaconda Py3.3
  FIX search and replace misstake
  DOC put the narrative documentation of roc_curve and roc_auc_score in one place
  ENH more explicit name for auc + consistency for scorer, fix scikit-learn#2096
  DOC: button layout tweak
  Website: bottom buttons
  DOC: bigger menu fonts
  DOC: layout tweaks
  Polishing on "Who's using scikit-learn"
  FIX typo in testimonials
  ENH testimonials img are now centered.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14
Development

No branches or pull requests
4 participants
@GaelVaroquaux @mblondel @amueller @arjoly
0