8000 _tree.pyx: Use np.intp_t instead of int · Issue #1466 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

_tree.pyx: Use np.intp_t instead of int #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glouppe opened this issue Dec 12, 2012 · 5 comments
Closed

_tree.pyx: Use np.intp_t instead of int #1466

glouppe opened this issue Dec 12, 2012 · 5 comments
Labels
Bug
Milestone
0.14-rc

Comments

@glouppe
Copy link
Contributor
glouppe commented Dec 12, 2012

As pointed out in #1458, the use of int for everything related to indexing numpy arrays might not be safe. @seberg recommends using np.intp_t instead.
@glouppe glouppe mentioned this issue Mar 27, 2013
Closed
@glouppe glouppe closed this as completed in 6a47c6f Apr 2, 2013
glouppe added a commit that referenced this issue Apr 2, 2013
@glouppe
Merge pull request #1823 from erg/issue-1466
c87d45d 
PR for Issue #1466
@glouppe glouppe reopened this Apr 2, 2013
@glouppe
Copy link
Contributor Author
glouppe commented Apr 2, 2013

Shall we let this one opened? #1823 solved the most common problems. Yet, bugs may still arise with billions of rows and/or features.

@amueller
Copy link
Member
amueller commented Apr 2, 2013

Maybe better leave it open :-/

@mrjbq7
Copy link
Contributor
mrjbq7 commented Apr 10, 2013

Wouldn't it be better to wait for another test case that fails and then address it then, instead of keeping tracker bugs open like this?

@ogrisel
Copy link
Member
ogrisel commented Apr 11, 2013

Wouldn't it be better to wait for another test case that fails and then address it then, instead of keeping tracker bugs open like this?

+1

@glouppe
Copy link
Contributor Author
glouppe commented Apr 11, 2013

Fine with me. I'll close this issue.

@glouppe glouppe closed this as completed Apr 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.14-rc
Development

No branches or pull requests
4 participants
@mrjbq7 @ogrisel @amueller @glouppe
0