8000 fetch_california_housing missing from the user guide · Issue #10555 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

fetch_california_housing missing from the user guide #10555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Jan 30, 2018 · 16 comments
Closed

fetch_california_housing missing from the user guide #10555

amueller opened this issue Jan 30, 2018 · 16 comments
Labels
Documentation Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve

Comments

@amueller
Copy link
Member

The fetch_california_housing function is missing from the dataset user guide:
http://scikit-learn.org/dev/datasets/index.html
@amueller amueller added Easy Well-defined and straightforward way to resolve Documentation good first issue Easy with clear instructions to resolve help wanted labels Jan 30, 2018
@amueller
Copy link
Member Author

details are here: http://www.dcc.fc.up.pt/~ltorgo/Regression/cal_housing.html

@kkang2097
Copy link
Contributor
kkang2097 commented Jan 31, 2018 •
edited
Loading

Hey how would i update the documentation? Sorry for being a newbie

@jnothman
Copy link
Member
jnothman commented Jan 31, 2018 via email

@divayjindal95
Copy link

@kkang2097 hey is it done ?

@kkang2097

Copy link
Contributor
kkang2097 commented Jan 31, 2018 •
edited
Loading

I think so, but it hasn't been closed so idk

@jnothman
Copy link
Member

@kkang2097 you didn't mention in your PR that it fixes this issue, so other users can't see that you've opened a PR. Also, your PR still needs work.

@kkang2097
Copy link
Contributor

Hmm, okay. Is there any guides you can point me to for how to contribute to open source projects?

@jnothman
Copy link
Member
jnothman commented Feb 1, 2018

http://scikit-learn.org/dev/developers/contributing.html

@rsivapr
Copy link
Contributor
rsivapr commented Feb 1, 2018

For the record: there is a WIP PR for this issue here: #10560

@kkang2097
Copy link
Contributor

Update: I already made the new description .rst file for the dataset, I just need to request a change to the index.rst file adding a reference to my proposed california_housing.rst file. Sorry, pretty hung up with classes / interviews right now. Will finish by the end of this week.

@kkang2097
Copy link
Contributor

Update 2: So in my pull request I updated the index.rst to include the California Housing dataset. But in the last line of the .rst file I wrote :add: /sklearn/datasets/descr/california_housing.rst, which is the location I want to add my proposed new description. Do I need to put in a second pull request? I mean, how do I propose modifying/adding 2 files in a single pull request?

@rsivapr
Copy link
Contributor
rsivapr commented Feb 2, 2018

Hi @kkang2097, Not sure I completely understand your questions.

Do I need to put in a second pull request?

No. You should keep all your changes in one PR.

modifying/adding 2 files in a single pull request

If you haven't used git before, you can learn the basics here : https://try.github.io/
Or use Github Desktop if you don't want to use the command line https://desktop.github.com/

@kkang2097
Copy link
Contributor

Update: Have finished, and uploaded a pull request.

@kkang2097 kkang2097 mentioned this issue Feb 12, 2018
Closed
@satishjasthi
Copy link
Contributor

@kkang2097 has your PR been accepted or it still requires some modifications

@Shreykhanna
Copy link

Hey Guys, Is the work done?

@qinhanmin2014 qinhanmin2014 mentioned this issue May 10, 2018
Closed
@aboucaud
Copy link
Contributor
aboucaud commented Jul 16, 2018 •
edited
Loading

Hi guys, I'm taking over this work as part of the sklearn sprint.

@aboucaud aboucaud mentioned this issue Jul 16, 2018
Closed
@jeremiedbb jeremiedbb mentioned this issue Jul 18, 2018
Merged
jnothman pushed a commit that referenced this issue Jul 25, 2018
@jeremiedbb @jnothman
DOC Clean up datasets loaders as part of the reorganization of the da…
9d649c5 
…taset section (#11319)

Standardize the datasets informations, as part of a more general reorganization of the dataset section in user guide, see #11083.

Fixes #10555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation 543D Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve
Projects
None yet
Milestone
No milestone
8 participants
@jnothman @amueller @rsivapr @aboucaud @divayjindal95 @satishjasthi @kkang2097 @Shreykhanna
0