10BC0 SLEP020: Simplifing Governance Changes by thomasjpfan · Pull Request #84 · scikit-learn/enhancement_proposals · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Jan 9, 2 10BC0 023

This SLEP proposes to permit governance changes through GitHub Pull Requests,
where a vote will also occur in the Pull Request.

Through the discussions in #74 and #81, I think we agree with moving governance changes to PRs. Fundamentally, this SLEP is a subset of SLEP019, but I think this SLEP will enable us to move more efficiently and make other changes, as discussed in SLEP019.

The last version of this SLEP is rendered online: https://scikit-learn-enhancement-proposals--84.org.readthedocs.build/en/84/slep020/proposal.html

Copy link
Member
@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @thomasjpfan!

I think this will help discussing SLEP 019 for effectively by dissociating discussions and changes' proposals for simplifying the governance and for recognizing all contributions.

Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

10BC0
Copy link
Member
@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as well.

Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr
Copy link
Member
lorentzenchr commented Jan 18, 2023

I think we can merge and call for a vote, right?

@jjerphan
Copy link
Member

I think we can merge and call for a vote, right?

I think people might not have seen this SLEP, yet might want to participate in its edition.

In order not to invalidate the vote with edition during its period, what if we define an end of edition for this first draft, iterate until the end of the edition, merge this draft, and call for a vote?

What do you think?

@thomasjpfan
Copy link
Member Author

I am planning to merge on Friday January 20 and calling for a vote at the same time.

Copy link
Member
@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it will make changes to sklearn more streamlined 🎉

@jjerphan
Copy link
Member

Should we reference all the links in the body of the SLEP in the dedicated "References and Footnotes" section instead?

@reshamas
Copy link
Member

Should we reference all the links in the body of the SLEP in the dedicated "References and Footnotes" section instead?

either, or. Some links are more important and maybe would be helpful to have in the body of the text.

@jjerphan
Copy link
Member

The SLEP is rendered online here (I have added this to the description of this PR).

Due to the concision of the SLEP, I think links are relatively accessible if they are in the section. One can also provide context in this section' entries. But that's mostly a nitpick from me.

Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0