-
-
Notifications
You must be signed in to change notification settings - Fork 33
SLEP020: Simplifing Governance Changes #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @thomasjpfan!
I think this will help discussing SLEP 019 for effectively by dissociating discussions and changes' proposals for simplifying the governance and for recognizing all contributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I think we can merge and call for a vote, right? |
I think people might not have seen this SLEP, yet might want to participate in its edition. In order not to invalidate the vote with edition during its period, what if we define an end of edition for this first draft, iterate until the end of the edition, merge this draft, and call for a vote? What do you think? |
|
I am planning to merge on Friday January 20 and calling for a vote at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it will make changes to sklearn more streamlined 🎉
|
Should we reference all the links in the body of the SLEP in the dedicated "References and Footnotes" section instead? |
either, or. Some links are more important and maybe would be helpful to have in the body of the text. |
|
The SLEP is rendered online here (I have added this to the description of this PR). Due to the concision of the SLEP, I think links are relatively accessible if they are in the section. One can also provide context in this section' entries. But that's mostly a nitpick from me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This SLEP proposes to permit governance changes through GitHub Pull Requests,
where a vote will also occur in the Pull Request.
Through the discussions in #74 and #81, I think we agree with moving governance changes to PRs. Fundamentally, this SLEP is a subset of SLEP019, but I think this SLEP will enable us to move more efficiently and make other changes, as discussed in SLEP019.
The last version of this SLEP is rendered online: https://scikit-learn-enhancement-proposals--84.org.readthedocs.build/en/84/slep020/proposal.html