10000 Add X,y,Y to ignored list by adrinjalali · Pull Request #69 · scikit-learn/enhancement_proposals · GitHub
[go: up one dir, main page]
Skip to content

Add X,y,Y to ignored list #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Add X,y,Y to ignored list #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7ffd7f
Add X,y,Y to ignored list
adrinjalali Jun 7, 2022
9c5611b
apply suggestion
adrinjalali Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions slep006/proposal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ Note that in the core library nothing is requested by default, except
the time of writing this proposal, all metadata requested in the core library
are sample aligned.

Also note that ``X``, ``y``, and ``Y`` input arguments are never automatically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only mention of upper-case Y in this document. (I suspect it is for PLS) Do you think this will be confusing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, from the perspective of the SLEP and the implementation, we don't really care why it's here. These arguments never enter the routing scheme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small interjection to bring information: Y is also used as an argument for some pairwise_d 9033 istances-based APIs.

Copy link
Member
@thomasjpfan thomasjpfan Dec 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of pairwise_distance, Y is a feature array. In the context of this SLEP, X and y are feature and target data, respectively.

In any case, I am okay with leaving this statement as is.

added to the routing mechanism and are always passed into their respective
methods.

Detailed description
--------------------

Expand Down
0