8000 Refactor lazy loading to use stubs & lazy_loader package by stefanv · Pull Request #6577 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Refactor lazy loading to use stubs & lazy_loader package #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2022
Merged

Refactor lazy loading to use stubs & lazy_loader package #6577

merged 3 commits into from
Oct 14, 2022

Conversation

stefanv
Copy link
Member
@stefanv stefanv commented Oct 12, 2022

No description provided.

@stefanv stefanv changed the title Refactor lazy loading Refactor lazy loading to use stubs Oct 12, 2022
@stefanv stefanv changed the title Refactor lazy loading to use stubs Refactor lazy loading to use stubs & lazy_loader package Oct 12, 2022
@stefanv stefanv marked this pull request as draft October 12, 2022 19:40
@stefanv
Refactor lazy loading
f56c3f5 
- Use lazy_loader package
- Use stubs to specify lazy imports
jarrodmillman
jarrodmillman approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor
@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanv
Copy link
Member Author
stefanv commented Oct 12, 2022

Once this is in, we can also do the other submodules. With the __init__.pyi format, it's much easier to transition than before.

@stefanv stefanv marked this pull request as ready for review October 13, 2022 03:55
@jarrodmillman jarrodmillman added this to the 0.20 milestone Oct 13, 2022
@jarrodmillman jarrodmillman requested a review from lagru October 13, 2022 23:49
lagru added 2 commits October 14, 2022 13:25
@lagru
Remove unused binary_blobs import
8b379e8
@lagru
Format imports consistently
df0e54d 
Format the PYI files consistently with filters/__init__.pyi by applying
black -S and isort --profile black.
lagru
lagru approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member
@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've removed an unused import in 8b379e8, and applied a consistent formatting to all PYI files in df0e54d.

Feel free to merge if you agree and once the CI is green. 👍

AF2C @lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Oct 14, 2022
@jarrodmillman jarrodmillman merged commit f2437de into scikit-image:main Oct 14, 2022
@lagru lagru mentioned this pull request Oct 20, 2022
Merged
This was referenced Jan 9, 2023
Closed
Closed
@grlee77 grlee77 mentioned this pull request Feb 7, 2023
Closed
@tlambert03 tlambert03 mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@lagru lagru lagru approved these changes

Assignees
No one assigned
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanv @jarrodmillman @lagru
0