-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Unify API on seed keyword for random seeds / generator #6258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey, there hasn't been any activity on this pull request for more than 180 days. For now, we have marked it as "dormant" until there is some new activity. You are welcome to reach out to people by mentioning them here or on our forum if you need more feedback! Otherwise, we would be thankful for a short update, for example if you would like to continue or if you are okay with someone else doing so. In any case, thank you for your contributions so far! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguably the depreciation cycle is getting squeezed here (deprecated_version='0.20', removed_version='1.0'
). I'm +1 in spite of this. /cc @scikit-image/core
The PR looks good 👍🏻 . Please, rebase onto the latest commit to rerun the tests. |
@grlee77 This one is good to go, right? Do you want to rebase and get it into the forthcoming release? |
I was slow for 0.20, but the conflicts have now been fixed. Will need one more commit to update the versions listed for the warning from |
Shouldn't we add a note to |
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Description
closes #5359
Unify on use of
seed
in the public API. Currently had a mixture of (sample_seed
,seed
,random_seed
,random_state
)Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.