8000 consistent zoom boundary behavior across SciPy versions by grlee77 · Pull Request #5131 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

consistent zoom boundary behavior across SciPy versions #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2020
Merged

consistent zoom boundary behavior across SciPy versions #5131

merged 1 commit into from
Dec 12, 2020

Conversation

grlee77
Copy link
Contributor
@grlee77 grlee77 commented Dec 12, 2020

closes #5130 (see explanation there)

This should get CI passing again for SciPy 1.6

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77
mark_boundary_subpixel fix
9062e0e 
switch internal mode used for zoom from 'reflect' to 'mirror' for consistency with
current behavior on SciPy >= 1.6
@grlee77 grlee77 added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Dec 12, 2020
@grlee77
Copy link
Contributor Author
grlee77 commented Dec 12, 2020

CI is passing now if anyone wants to review & merge. Then we need to backport to v0.18.x

jni
jni approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member
@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the quick fix @grlee77!!!

@jni jni mentioned this pull request Dec 12, 2020
Closed
@hmaarrfk hmaarrfk merged commit 66c271e into scikit-image:master Dec 12, 2020
@jni
Copy link
Member
jni commented Dec 12, 2020

@meeseeksdev backport to v0.18.x

@meeseeksmachine meeseeksmachine mentioned this pull request Dec 12, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Dec 12, 2020
@hmaarrfk @meeseeksmachine
Backport PR scikit-image#5131: consistent zoom boundary behavior acro…
30a47cd 
…ss SciPy versions
jni pushed a commit that referenced this pull request Dec 13, 2020
@meeseeksmachine @hmaarrfk
Backport PR #5131 on branch v0.18.x (consistent zoom boundary behavio…
7f583b5 
…r across SciPy versions) (#5133)

Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@alexdesiqueira alexdesiqueira mentioned this pull request Dec 15, 2020
Closed
@grlee77 grlee77 deleted the mark_boundary_fix branch July 8, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

Assignees
No one assigned
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre builds broken by scipy 1.6.0rc1
3 participants
@grlee77 @jni @hmaarrfk
0