Use v{} for version tags with pooch #5104
Conversation
|
Reference thread on Zulip: https://skimage.zulipchat.com/#narrow/stream/175598-general/topic/release.200.2E18/near/218161832 But, looks like this works for versions but not master... Hold please... |
|
We'll need a second person to review/approve/merge here. |
| @@ -125,7 +125,12 @@ def create_image_fetcher(): | |||
| # This helps pooch understand that it should look in master | |||
| # to find the required files | |||
| pooch_version = __version__.replace('.dev', '+') | |||
| url = "https://github.com/scikit-image/scikit-image/raw/{version}/skimage/" | |||
| if '+' in pooch_version: | |||
There was a problem hiding this comment.
@hmaarrfk for master, the data lives in github.com/scikit-image/scikit-image/raw/master/skimage/..., while for version tags, it's in github.com/scikit-image/scikit-image/raw/v0.18.0/skimage/..., for example.
Technically, the approach is not quite correct: the v0.18.x branch will still look in master. This happens to work, but might not always. For now, it gets us unstuck. In the future, maybe we move to setuptools_scm, which would solve a lot of issues more elegantly.
There was a problem hiding this comment.
This, and pooch knows how to convert internally version to master so that in the url it's master, I guess?
|
@scikit-image/core please review/merge, this is a fix needed for the release. |
|
Thank you all, merging. |
|
@emmanuelle I understand that the CI failure is resolved by #5109, right? |
|
@meeseeksdev backport to v0.18.x |
Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
Description
The pooch URL was incorrect for released version tags given our convention to use v0.18.0 rather than just 0.18.0 for releases.
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.