8000 disable Travis-CI builds by grlee77 · Pull Request #5099 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

disable Travis-CI builds #5099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2020
Merged

disable Travis-CI builds #5099

merged 2 commits into from
Dec 5, 2020

Conversation

grlee77
Copy link
Contributor
@grlee77 grlee77 commented Dec 4, 2020

We do not have sufficient free credits to run this test matrix on their new billing policy.

We may want to re-enable for non-x86 architectures such as AArch64 going forward

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77
disable Travis-CI builds
b593085 
We do not have sufficient free credits to run this matrix on their new
billing policy.

We may want to re-enable for non-x86 architectures such as AArch64 going forward
@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Dec 4, 2020
@grlee77
Copy link
Contributor Author
grlee77 commented Dec 4, 2020

Not sure if we want to keep this file around for future use or just rely on the git history for that? I think we may want to enable it again for ARM only going forward and perhaps only in the wheels repo. I think all repos under a single organization share a common pool of credits.

@emmanuelle
Copy link
Member

I also had the impression that credits are shared within an org, so 👍 for disabling Travis in this repo. I'd be in favor of removing the file altogether and relying on git history, but it's not a strong preference so I'm fine with merging the PR. I'm just a bit confused about the CI: it looks like all builds were cancelled.

@grlee77
Copy link
Contributor Author
grlee77 commented Dec 4, 2020

I manually cancelled them since there was nothing new to test

emmanuelle
emmanuelle approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member
@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grlee77, approved! Regarding CI, I also opened #5097 yesterday. Maybe we'll have green PRs soon ;-).

@emmanuelle
Copy link
Member

Oh and there are also the files in tools/travis which could be removed. (some of tools/travis/notes.txt could be useful for the other CI tools). Can be done in another PR ;-).

@jni
Copy link
Member
jni commented Dec 5, 2020

Thank you @grlee77! --pre build failures should be fixed in #5103

@jni jni merged commit 73c2c77 into scikit-image:master Dec 5, 2020
jni pushed a commit to jni/scikit-image that referenced this pull request Dec 7, 2020
@grlee77 @jni
disable Travis-CI builds (scikit-image#5099)
6f879b9
@jni jni mentioned this pull request Dec 7, 2020
Merged
@grlee77 grlee77 mentioned this pull request Dec 7, 2020
Closed
grlee77 added a commit that referenced this pull request Dec 7, 2020
@jni @emmanuelle
@FirefoxMetzger @grlee77
Recent backports from skimage master (#5111)
df9170c 
* Add data optional reqs to allow pip install scikit-image[data] (#5105)

* Fix compilation error in XCode 12 (#5107)

* Fix compilation error in XCode 12

* Add cdef externs

* moved cdefs to pyx files

* replaced cdef statements

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>

* OpenMP support in MSVC (#4924)

* disable Travis-CI builds (#5099)

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
Co-authored-by: Sebastian Wallkötter <sebastian@wallkoetter.net>
Co-authored-by: Gregory R. Lee <grlee77@gmail.com>
@grlee77 grlee77 deleted the travis_disable branch July 8, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle approved these changes

@jni jni jni approved these changes

Assignees
No one assigned
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grlee77 @emmanuelle @jni
0