8000 Add 0.18 release notes by jni · Pull Request #5085 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]

Skip to content

Add 0.18 release notes #5085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2020
Merged

Add 0.18 release notes #5085

merged 4 commits into from
Nov 27, 2020

Conversation

jni
Copy link
Member
@jni jni commented Nov 27, 2020

Description

This adds the candidate release notes for 0.18.0. 🎉

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

Copy link
Member
@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jni! A few comments left as suggestions. Since it's doc and non-controversial, feel free to merge.

Comment on lines +32 to +34
(#4922), ``data.human_mitosis`` (#4939), ``data.cells3d`` (#4951), and
``data.vortex`` (#5041). Also note that the image for ``data.camera`` has
been changed due to copyright issues (#4913).
Copy link
Member
@emmanuelle emmanuelle Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(#4922), ``data.human_mitosis`` (#4939), ``data.cells3d`` (#4951), and
``data.vortex`` (#5041). Also note that the image for ``data.camera`` has
been changed due to copyright issues (#4913).
(#4922), ``data.human_mitosis`` (#4939), ``data.cells3d`` (#4951),
``data.skin`` (#4739) and ``data.vortex`` (#5041). Also note that
the image for ``data.camera`` has been changed due to copyright
issues (#4913).

@emmanuelle
Copy link
Member

I'm not sure about why the Azure build fails, maybe getting rid of the italic formatting issue will fix this.

@emmanuelle
Copy link
Member

So please consider the PR half-approved only, CI should be green.

jni and others added 2 commits November 27, 2020 19:30
Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
52 authors added to this release [alphabetical by first name or login]
----------------------------------------------------------------------

A warm thank you to all contributors who added to this release. A fraction of contributors were first-time contributors to open source and a much larger fraction first-time contributors to scikit-image. It's a great feeling for maintainers to welcome new contributors, and the diversity of scikit-image contributors is surely a big strength of the package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be reformat this to 80 characters length lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfezzani I didn't want to go through another cycle of review just for minor formatting. There's actually quite a few lines to reformat to get the whole file in under 80c. I'll make this a PR between the RC and the actual release.

@jni jni merged commit c659235 into scikit-image:v0.18.x Nov 27, 2020
@jni jni deleted the 0.18-release-notes branch November 27, 2020 09:46
jni added a commit to jni/scikit-image that referenced this pull request Dec 5, 2020
* Add 0.18 release notes

* Apply suggestions from code review

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>

* Add quotes to prevent rst interpreting _ as link

* Update doc/release/release_0.18.rst

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0