10000 TEST - DO NOT MERGE remove lily by sciunto · Pull Request #4959 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

TEST - DO NOT MERGE remove lily #4959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

TEST - DO NOT MERGE remove lily #4959

wants to merge 6 commits into from

Conversation

sciunto
Copy link
Member
@sciunto sciunto commented Sep 5, 2020

Description

A test for #4958

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@sciunto sciunto mentioned this pull request Sep 5, 2020
Closed
@sciunto sciunto changed the title TEST - DO NOT MERGE remove lili TEST - DO NOT MERGE remove lily Sep 5, 2020
@hmaarrfk
Copy link
Member
hmaarrfk commented Sep 5, 2020 

Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx\cmd\build.py", line 275, in build_main
    args.tags, args.verbosity, args.jobs, args.keep_going)
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx\application.py", line 278, in __init__
    self._init_builder()
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx\application.py", line 334, in _init_builder
    self.events.emit('builder-inited')
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx\events.py", line 99, in emit
    results.append(callback(self.app, *args))
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx_gallery\gen_gallery.py", line 434, in generate_gallery_rst
    seen_backrefs)
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx_gallery\gen_rst.py", line 362, in generate_dir_rst
    fname, target_dir, src_dir, gallery_conf, seen_backrefs)
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx_gallery\gen_rst.py", line 847, in generate_file_rst
    gallery_conf)
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx_gallery\gen_rst.py", line 976, in save_rst_example
    gallery_conf)
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\site-packages\sphinx_gallery\binder.py", line 112, in gen_binder_rst
    binder_logo_path = os.path.relpath(binder_logo, gallery_conf['src_dir'])
  File "C:\hostedtoolcache\windows\Python\3.6.8\x64\lib\ntpath.py", line 584, in relpath
    path_drive, start_drive))
ValueError: path is on mount 'C:', start on mount 'D:

@sciunto
Copy link
Member Author
sciunto commented Sep 5, 2020 •
edited
Loading

oh, wait. Isn't it related to this recent change in sphinx-gallery? sphinx-gallery/sphinx-gallery#735

@sciunto
Copy link
Member Author
sciunto commented Sep 5, 2020

they released a version 3 days ago... Ping @larsoner @lucyleeow

@lucyleeow
Copy link

Yes, the error is a line I changed recently. I did have a bad feeling about it - my bad, I'll look into it.

@sciunto
Copy link
Member Author
sciunto commented Sep 5, 2020

thanks for commenting so quickly @lucyleeow :)

@sciunto sciunto closed this Sep 5, 2020
@lucyleeow lucyleeow mentioned this pull request Sep 5, 2020
Closed
@sciunto sciunto mentioned this pull request Sep 7, 2020
Closed
@mkcor mkcor mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sciunto @hmaarrfk @lucyleeow
0