8000 Deprecate viewer and skivi script, will be removed in 0.20 by sciunto · Pull Request #4954 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Deprecate viewer and skivi script, will be removed in 0.20 #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2020
Merged

Deprecate viewer and skivi script, will be removed in 0.20 #4954

merged 5 commits into from
Sep 6, 2020

Conversation

sciunto
Copy link
Member
@sciunto sciunto commented Sep 1, 2020

Description

Hopefully, will definitely close #4081

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@sciunto sciunto added 🔧 type: Maintenance Refactoring and maintenance of internals 🔽 Deprecation Involves deprecation labels Sep 1, 2020
@sciunto sciunto added this to the 0.18 milestone Sep 1, 2020
@pep8speaks
Copy link
pep8speaks commented Sep 1, 2020 •
edited
Loading

Hello @sciunto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 96:80: E501 line too long (82 > 79 characters)
Line 359:80: E501 line too long (82 > 79 characters)

Comment last updated at 2020-09-06 02:59:14 UTC

@sciunto sciunto marked this pull request as draft September 1, 2020 09:22
rfezzani
rfezzani approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member
@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you @sciunto!

@sciunto sciunto marked this pull request as ready for review September 1, 2020 10:09
@sciunto
Copy link
Member Author
sciunto commented Sep 5, 2020

rebased to get a greener CI.

@jni jni merged commit afc006c into scikit-image:master Sep 6, 2020
@jni
Copy link
Member
jni commented Sep 6, 2020

Awesome, thank you @sciunto!

@sciunto sciunto deleted the viewer_skivi branch September 6, 2020 11:17
@sciunto sciunto mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@rfezzani rfezzani rfezzani approved these changes

Assignees
No one assigned
Labels
🔽 Deprecation Involves deprecation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.

Consider deprecating viewer and skivi
4 participants
@sciunto @pep8speaks @jni @rfezzani
0