8000 Fix and improve entropy example by sciunto · Pull Request #4904 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Fix and improve entropy example #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2020
Merged

Fix and improve entropy example #4904

merged 5 commits into from
Aug 12, 2020

Conversation

sciunto
Copy link
Member
@sciunto sciunto commented Aug 9, 2020

Description

See #4895

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link
pep8speaks commented Aug 9, 2020 •
edited
Loading

Hello @sciunto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 15:80: E501 line too long (80 > 79 characters)

Comment last updated at 2020-08-09 10:41:54 UTC

@sciunto sciunto mentioned this pull request Aug 9, 2020
Closed
emmanuelle
emmanuelle reviewed Aug 9, 2020
View reviewed changes
doc/examples/filters/plot_entropy.py Outdated
To detect the central square, we compute the local entropy measure using a
circular structuring element of a radius big enough to capture the local gray
level distribution. The second example shows how to detect texture in the camera
image using a smaller structuring element.

"""

##################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the length of the line of #' needs to be longer for sphinx-gallery to detect that it's a new block of text. See the artifact https://162-2014929-gh.circle-artifacts.com/0/doc/build/html/auto_examples/filters/plot_entropy.html#sphx-glr-auto-examples-filters-plot-entropy-py where the two figures are together at the top.

emmanuelle
emmanuelle reviewed Aug 9, 2020
View reviewed changes
doc/examples/filters/plot_entropy.py Outdated

fig.tight_layout()

# Second example: texture detection.
###################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

emmanuelle
emmanuelle approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member
@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sciunto!

@sciunto sciunto added action: mrg+1 📄 type: Documentation Updates, fixes and additions to documentation labels Aug 9, 2020
@sciunto sciunto mentioned this pull request Aug 10, 2020
Closed
@jni jni merged commit eff9f62 into scikit-image:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle approved these changes

@jni jni jni approved these changes

Assignees
No one assigned
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sciunto @pep8speaks @emmanuelle @jni
0