8000 Update docstring for rgb2lab by iofall · Pull Request #4839 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Update docstring for rgb2lab #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2020
Merged

Update docstring for rgb2lab #4839

merged 3 commits into from
Jul 12, 2020

Conversation

iofall
Copy link
Contributor
@iofall iofall commented Jul 11, 2020

Description

Fixes #4514

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link
pep8speaks commented Jul 11, 2020 •
edited
Loading

Hello @cedarfall! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-11 20:01:01 UTC

@emmanuelle
Copy link
Member

Thank you! Can you just remove the trailing white space in the parentheses as asked for by the PEP8 bot, and push a new commit to your branch (this will update the PR) ?

@emmanuelle
Copy link
Member

Thanks @cedarfall ! Looks good to me, I'm just waiting for the continuous integration tests to complete before approving.

emmanuelle
emmanuelle approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member
@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cedarfall !

@jni jni merged commit 48f8597 into scikit-image:master Jul 12, 2020
@alexdesiqueira alexdesiqueira mentioned this pull request Jul 14, 2020
Closed
745D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle approved these changes

@jni jni jni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify that rgb2lab function is relative only to sRGB colorspace
4 participants
@iofall @pep8speaks @emmanuelle @jni
0