8000 Simplify equivalent_diameter function by OGordon100 · Pull Request #4819 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Simplify equivalent_diameter function #4819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2020
Merged

Simplify equivalent_diameter function #4819

merged 1 commit into from
Jul 11, 2020

Conversation

OGordon100
Copy link
Contributor

The equivalent_diameter function in regionprops is a little messy, and only works with 2/3 dimensions (although I think this is a moot point as the regionprops function only applies to 2/3D images).

Regardless, it's a little messy, and the proposed PR neatens this up and removes needless if statements

jni
jni approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member
@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you!

@jni jni mentioned this pull request Jul 6, 2020
Closed
@alexdesiqueira alexdesiqueira merged commit 03dce75 into scikit-image:master Jul 11, 2020
@alexdesiqueira
Copy link
Member

Thank you @OGordon100!

@OGordon100 OGordon100 deleted the OGordon100-patch-2 branch July 7, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OGordon100 @alexdesiqueira @jni
0