8000 try to fix ci which is broken because of pyqt5 last version by emmanuelle · Pull Request #4788 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

try to fix ci which is broken because of pyqt5 last version #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2020
Merged

try to fix ci which is broken because of pyqt5 last version #4788

merged 2 commits into from
Jun 14, 2020

Conversation

emmanuelle
Copy link
Member
@emmanuelle emmanuelle commented Jun 12, 2020 •
edited
Loading

The CI is broken on Travis, probably following the latest release of pyqt5. I noticed that I could only pip install this pyqt5 release using a recent pip so this PR is an attempt to fix the CI. (edit:didn't work, I just excluded the last version)

@emmanuelle
Copy link
Member Author

I don't really understand why the failing test is failing (seems to be a multithreading issue, can't reproduce locally) so I just excluded the last version

@emmanuelle emmanuelle changed the title try to fix ci (pip install pyqt5) try to fix ci which is broken because of pyqt5 last version Jun 12, 2020
@hmaarrfk
Copy link
Member

the .0 release will almost surely have hiccups with pyqt ;)

@jni jni merged commit abe667d into scikit-image:master Jun 14, 2020
@jni
Copy link
Member
jni commented Jun 14, 2020

Thanks @emmanuelle!

@hmaarrfk
Copy link
Member

thanks a bunch!

@alexdesiqueira alexdesiqueira mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk approved these changes

@jni jni jni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmanuelle @hmaarrfk @jni
0