8000 Improving register rotation example with notes and references by mellertd · Pull Request #4723 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Improving register rotation example with notes and references #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2020
Merged

Improving register rotation example with notes and references #4723

merged 4 commits into from
Jul 6, 2020

Conversation

mellertd
Copy link
Contributor

Description

Follow up on discussion in #4515. I also broke things up a little differently to fix some problems with how the example is rendering on the website.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@alexdesiqueira alexdesiqueira added the 📄 type: Documentation Updates, fixes and additions to documentation label May 14, 2020
@alexdesiqueira alexdesiqueira requested review from jni and emmanuelle May 14, 2020 17:10
@alexdesiqueira
Copy link
Member

Thank you @mellertd, this looks great!

@alexdesiqueira alexdesiqueira mentioned this pull request May 18, 2020
Closed
@mellertd
Copy link
Contributor Author

Just checking on whether this is ok?

jni
jni reviewed Jul 1, 2020
View reviewed changes
jni
jni reviewed Jul 1, 2020
View reviewed changes
@jni
Copy link
Member
jni commented Jul 1, 2020

@mellertd sorry, busy times! This is fine, just suggested a typo fix and maybe adding DOIs if you get a chance. Otherwise great PR, apologies for the silence! =)

@jni jni merged commit 91a46e3 into scikit-image:master Jul 6, 2020
@mellertd mellertd deleted the reg_rot_example branch July 8, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@emmanuelle emmanuelle Awaiting requested review from emmanuelle

Assignees
No one assigned
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mellertd @alexdesiqueira @jni
0