8000 Perform todo tasks for 0.17! by sciunto · Pull Request #4691 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]

Skip to content

Perform todo tasks for 0.17! #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2020
Merged

Perform todo tasks for 0.17! #4691

merged 6 commits into from
May 12, 2020

Conversation

sciunto
Copy link
Member
@sciunto sciunto commented May 12, 2020

Description

Some tasks were not performed. oops. Cc @emmanuelle

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@emmanuelle
Copy link
Member

oops indeed :-)

@emmanuelle
Copy link
Member

I checked that the TODO was mentioned in the release notes and it is!

Copy link
Member
@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sciunto! We need a second 👍 here :-).

@hmaarrfk
Copy link
Member

are we deciding to backport these? No opinion, just a question

@emmanuelle
Copy link
Member

I think so, although it's a bit delicate. We said we would make these changes so not making them is a bug (sorry for this). And most people haven't upgraded yet so they won't notice. Thoughts?

@emmanuelle
Copy link
Member

The other solution is to release 0.18 in a month :-).

@hmaarrfk hmaarrfk merged commit 2e3b4b0 into scikit-image:master May 12, 2020
@hmaarrfk
Copy link
Member

Cool, Well ill let the release manager of 0.17.2 decide ;)

@emmanuelle
Copy link
Member

Still interested in knowing other opinions before calling Mr meeseeksdev. But I guess the reason why @sciunto made quickly this PR is so that it could be in 0.17.2.

@sciunto sciunto deleted the todo0.17 branch May 12, 2020 20:04
@sciunto
Copy link
Member Author
sciunto commented May 12, 2020

IMO, I would backport.

@sciunto sciunto restored the todo0.17 branch May 12, 2020 20:05
@sciunto
Copy link
Member Author
sciunto commented May 12, 2020

@meeseeksdev backport to v0.17.x

@sciunto
Copy link
Member Author
sciunto commented May 12, 2020

It's also to open the debate in #4698 :)

emmanuelle pushed a commit that referenced this pull request May 13, 2020
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@jni
Copy link
Member
jni commented May 19, 2020

Hi everyone, I missed this PR, thank you all for handling it. One note I would add to this (and I'll make an issue and try to make a PR as soon as I get a chance) is that I would replace the ..deprecated sections with ..versionchanged sections, rather than delete them altogether. I think they are very useful for people getting errors in their code to quickly figure out what happened without reading several lots of release notes.

@sciunto sciunto deleted the todo0.17 branch May 19, 2020 08:15
@sciunto
8EEF Copy link
Member Author
sciunto commented May 19, 2020

good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0