-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Perform todo tasks for 0.17! #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oops indeed :-) |
I checked that the TODO was mentioned in the release notes and it is! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sciunto! We need a second 👍 here :-).
are we deciding to backport these? No opinion, just a question |
I think so, although it's a bit delicate. We said we would make these changes so not making them is a bug (sorry for this). And most people haven't upgraded yet so they won't notice. Thoughts? |
The other solution is to release 0.18 in a month :-). |
Cool, Well ill let the release manager of 0.17.2 decide ;) |
Still interested in knowing other opinions before calling Mr meeseeksdev. But I guess the reason why @sciunto made quickly this PR is so that it could be in 0.17.2. |
IMO, I would backport. |
@meeseeksdev backport to v0.17.x |
It's also to open the debate in #4698 :) |
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Hi everyone, I missed this PR, thank you all for handling it. One note I would add to this (and I'll make an issue and try to make a PR as soon as I get a chance) is that I would replace the |
good point. |
Description
Some tasks were not performed. oops. Cc @emmanuelle
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.