8000 Add ORB float32 support by rfezzani · Pull Request #4684 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Add ORB float32 support #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2020
Merged

Add ORB float32 support #4684

merged 2 commits into from
May 12, 2020

Conversation

rfezzani
Copy link
Member

Description

Fixes #4675.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@rfezzani rfezzani added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label May 12, 2020
hmaarrfk
hmaarrfk approved these changes May 12, 2020
View reviewed changes
Copy link
Member
@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, awesome

skimage/feature/tests/test_orb.py
@@ -120,3 +122,10 @@ def test_no_descriptors_extracted_orb():
detector_extractor = ORB()
with testing.raises(RuntimeError):
detector_extractor.detect_and_extract(img)


@pytest.mark.parametrize('dtype', ['float32', 'float64', 'uint8', 'int'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Int64?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I am trying to find a more elaborated test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me still merge this now you're welcome to submit an other PR with a more complete test of course.

@emmanuelle emmanuelle merged commit 18e9b40 into scikit-image:master May 12, 2020
@emmanuelle
Copy link
Member

@meeseeksdev backport to v0.17.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request May 12, 2020
@rfezzani @meeseeksmachine
Backport PR scikit-image#4684: Add ORB float32 support
ca35c2b
@meeseeksmachine meeseeksmachine mentioned this pull request May 12, 2020
Merged
@rfezzani
Copy link
Member Author

@emmanuelle, I found that orb_loop only supports double, I will come with a PR for fixing this also soon

emmanuelle pushed a commit that referenced this pull request May 12, 2020
@meeseeksmachine @rfezzani
Backport PR #4684: Add ORB float32 support (#4688)
468f55f 
Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
@rfezzani rfezzani mentioned this pull request May 12, 2020
Merged
8 tasks
@alexdesiqueira alexdesiqueira mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle left review comments

@hmaarrfk hmaarrfk hmaarrfk approved these changes

Assignees
No one assigned
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ORB detection doesn't work on 32 bit float input
3 participants
@rfezzani @emmanuelle @hmaarrfk
0