Expose recently introduced map_array function in skimage.util #4646
Conversation
|
Hello @emmanuelle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-05-06 09:23:02 UTC |
There was a problem hiding this comment.
@emmanuelle I've made two minor and optional suggestions, otherwise happy for this to get merged once tests pass! Thank you!
|
To clarify what @emmanuelle meant by "other tasks": this would close #1396. It needs a gallery example but it's probably not worth holding up release for it. |
Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
|
I am thinking about submitting a PR to create a |
|
It is green now :-). |
|
Merged ;) Thank you @emmanuelle |
|
@rfezzani I like your new module idea. |
|
Yes @jni, there is no hurry ;) |
|
Continuing the tangent, our top-level submodule naming convention is direct, not plural, and tends not to include portmanteaus. Refactoring the label infrastructure makes some sense to me. The best submodule name would be |
Since this function can be useful for other tasks. I also wondered whether we should expose
ArrayMapor not (at the moment it is not and for skimage developers it's easy to import it from its location). It's easy to change of course.