8000 Fix broken link by sciunto · Pull Request #4639 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Fix broken link #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

Fix broken link #4639

merged 1 commit into from
May 6, 2020

Conversation

sciunto
Copy link
Member
@sciunto sciunto commented May 5, 2020

Description

Fixes #4594

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@sciunto sciunto requested review from emmanuelle and jni May 5, 2020 06:41
@pep8speaks
Copy link
pep8speaks commented May 5, 2020 •
edited
Loading

Hello @sciunto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1450:80: E501 line too long (116 > 79 characters)
Line 1505:80: E501 line too long (116 > 79 characters)

Comment last updated at 2020-05-06 09:21:34 UTC

@sciunto sciunto added the 🔧 type: Maintenance Refactoring and maintenance of internals label May 5, 2020
@sciunto sciunto added this to the 0.17 milestone May 5, 2020
jni
jni approved these changes May 6, 2020
View reviewed changes
Copy link
Member
@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would we do without the wayback machine!

@sciunto
Copy link
Member Author
sciunto commented May 6, 2020

time traveling

@emmanuelle
Copy link
Member

I'll merge when the CI is green

@emmanuelle emmanuelle merged commit 67b6899 into scikit-image:master May 6, 2020
@sciunto sciunto deleted the 404 branch May 6, 2020 12:26
@emmanuelle emmanuelle mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@emmanuelle emmanuelle Awaiting requested review from emmanuelle

Assignees
No one assigned
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

Broken link in separate_stains docstring
4 participants
@sciunto @pep8speaks @emmanuelle @jni
0