8000 MAINT: remove unused cython file by grlee77 · Pull Request #4633 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

MAINT: remove unused cython file #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

MAINT: remove unused cython file #4633

merged 1 commit into from
Aug 7, 2020

Conversation

grlee77
Copy link
Contributor
@grlee77 grlee77 commented Apr 30, 2020

Description

cmorph.pyx appears to be dead code for 2D greyscale erosion/dilation
It was replaced by n-d scipy.ndimage equivalents several years ago (#1310).

Checklist

N/A

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77
MAINT: remove unused cython file
df4a218 
cmorph.pyx was replaced by use of scipy.ndimage morphology operations in 56764f8
@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Apr 30, 2020
@grlee77 grlee77 added this to the 0.16 milestone Apr 30, 2020
@hmaarrfk
Copy link
Member

It seems that pooch isn't a smooth transition process when moving files around (i.e. the dev points to master, while, we may be on a different branch during the PR process).

@sciunto sciunto modified the milestones: 0.16, 0.17 May 2, 2020
@emmanuelle emmanuelle mentioned this pull request May 4, 2020
Closed
@emmanuelle
Copy link
Member

Removing code, yeah!! Merging.

@emmanuelle emmanuelle merged commit 4119ad3 into scikit-image:master Aug 7, 2020
@grlee77 grlee77 deleted the remove_dead_grey_morphology_code branch August 19, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk approved these changes

Assignees
No one assigned
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@grlee77 @hmaarrfk @emmanuelle @sciunto
0