8000 Broken plot in userguide fixed by fiza11 · Pull Request #4541 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]

Skip to content

Broken plot in userguide fixed #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

fiza11
Copy link
@fiza11 fiza11 commented Mar 30, 2020
  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

8000
@rfezzani rfezzani added 🩹 type: Bug fix Fixes unexpected or incorrect behavior 📄 type: Documentation Updates, fixes and additions to documentation labels Mar 30, 2020
@sciunto
Copy link
Member
sciunto commented Mar 31, 2020

Thanks for submitting the patch. Please, could you make the text outside the code?
A crash course on NumPy for images — skimage v0 17 dev0 docs

@emmanuelle emmanuelle mentioned this pull request Apr 4, 2020
@sciunto
Copy link
Member
sciunto commented Apr 7, 2020

@emmanuelle Should we remove the plot instruction or try to fix it?

I thought it was a simple issue but looks like I underestimated the complexity...

@sciunto
Copy link
Member
sciunto commented Sep 5, 2020

I'm closing this PR as another fix was proposed See #4540 Thanks for contributing and I hope the next PR from you will be merged

@sciunto sciunto closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior 📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0