8000 Incorrect deprecation message for `draw.circle` · Issue #4884 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

Incorrect deprecation message for draw.circle #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jni opened this issue Aug 3, 2020 · 1 comment · Fixed by #4908
Closed

Incorrect deprecation message for draw.circle #4884

jni opened this issue Aug 3, 2020 · 1 comment · Fixed by #4908
Labels
🔰 Good first issue A good task for those new to the library
Milestone
0.18

Comments

@jni
Copy link
Member
jni commented Aug 3, 2020

Description

draw.circle is deprecated in favour of draw.disk. But the deprecation warning says that it's deprecated in favour of disk.circle! 🤦 Oops!

Way to reproduce

from skimage import draw
_ = draw.circle(5, 5, 5)  # r, c, radius

gives

FutureWarning: circle is deprecated in favor of disk.circle will be removed in version 0.19

Version information

skimage 0.17.2/master
@jni jni added the 🔰 Good first issue A good task for those new to the library label Aug 3, 2020
@sciunto sciunto added this to the 0.18 milestone Aug 6, 2020
@sciunto
Copy link
Member
sciunto commented Aug 6, 2020

I think it was supposed to say "circle is deprecated in favor of disk. circle will be removed in version 0.19"

This was referenced Aug 10, 2020
Closed
Closed
sciunto added a commit to sciunto/scikit-image that referenced this issue Aug 11, 2020
@sciunto
Fix deprecation msg, scikit-image#4884
b0047cd
@sciunto sciunto mentioned this issue Aug 11, 2020
Merged
lagru pushed a commit that referenced this issue Aug 11, 2020
@sciunto
Fix deprecation msg, #4884 (#4908)
7853897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔰 Good first issue A good task for those new to the library
Projects
None yet
Milestone
0.18
2 participants
@sciunto @jni
0