8000 FindF2PY: ensure generic f2py executable is looked up first by smiet · Pull Request #1111 · scikit-build/scikit-build · GitHub
[go: up one dir, main page]
Skip to content

FindF2PY: ensure generic f2py executable is looked up first #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FindF2PY: ensure generic f2py executable is looked up first #1111

wants to merge 1 commit into from

Conversation

smiet
Copy link
@smiet smiet commented Aug 6, 2024 •
edited
Loading

In issue #449 a change was made to the resolution of F2py to support python2 builds and prefer the versioned f2pyx over an unversioned.

scikit-build/skbuild/resources/cmake/FindF2PY.cmake

Line 69 in 5b20908

find_program(F2PY_EXECUTABLE NAMES f2py f2py${PYTHON_VERSION_MAJOR})

This made sense at the time, but with the now final deprecation of python2, and numpy dropping f2py3 in version 1.26 this change has come to bite us.

Now if using a virtual environment with a version of numpy>1.26, but an OS/system that has a python with numpy<1.26, cmake will prefer the f2py3 of the OS, leading to hard-to-diagnose problems.

With numpy>=2.0 C-API changes, code compiled with the systems f2py will not run in the environment.

@sdrave
Copy link
sdrave commented Aug 8, 2024

We have been affected by this issue as well. Trying to pip install python-control/slycot in a venv will fail on any machine with a globally installed numpy<2. pip will pull numpy 2 as a build dependency and use its headers, but cmake will select the system f2py to generate the bindings.

@smiet
Copy link
Author
smiet commented Aug 8, 2024

A quick and dirty workaround is to add a symlink called f2py3 in your virtual environment:
$ ln -s /path/to/venv/bin/f2py /path/to/venv/bin/f2py3
Then CMake will look there first and not find the system's executable.

@pmli pmli mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smiet @sdrave
0