Configure cjdk behavior via scyjava.config #83
Conversation
| Bootstrap a Java installation: | ||
| >>> from scyjava import config, jimport | ||
| >>> config.set_java_constraints(fetch=True, vendor='zulu', version='17') |
There was a problem hiding this comment.
Wow, I was about to request you as a reviewer, but... 🚀
There was a problem hiding this comment.
i noticed the brief addition of add_kwargs ... I assume it's coming elsewhere. my only comment was gonna be whether that might be too generic? (though I know it matches add_options). perhaps add_jvm_kwargs?
There was a problem hiding this comment.
Yeah, rather than deprecate the term options in favor of jvm_options, I decided to just leave it and call the kwargs kwargs, to maintain a foolish consistency. We could of course deprecate both in favor of clearer names.
The reason it appeared only "briefly" is because I ended up moving a bunch of unrelated (to this PR) commits over to main, which included the kwargs addition.
Note that I screwed up releasing scyjava 1.11.0: it does not include this PR, even though it had been merged, because I forgot to fast-forward my local main branch. So I then immediately did so and released 1.12.0 as well. The only "harm" there is that 1.11.0 now contains the fetch_java keyword argument to start_jvm which I then removed, breaking SemVer. But hopefully no one will use 1.11.0 and then complain about this. 😅
This branch updates the awesome JDK/JRE caching to support configuration via the scyjava.config rather than via environment variables.