bugfix: put tokenmakers in hashmap with the correct name #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I just found that bug which is related to naming of TokenMakers. Assume you have a new scripting language, e.g. called "Te Oki" which comes with a TokenMaker marked as SciJava plugin having the name "Te Oki". It will be put in the hashmap of the token maker factory with key "text/Te Oki" link
Later, when the user selectes that scipting language, the editor searches for a map entry named "text/te-oki" but not "text/Te Oki". link
I assume there is some kind of standard that these map entries shouldn't have spaces or upper case characters. Thus, I'm suggesting this bugfix.
Let me know if I can help with anything.
Cheers,
Robert