Add input provider plugins #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes batch processing extensible by allowing plugins implementing the BatchInputProvider interface to support custom script parameter inputs, such as net.imagej.Dataset which will be provided in the imagej-plugins-batch project. Because BatchService now extends HandlerService, I needed to rename the supports() methods more concisely into supportsModule() and supportsItem(), to avoid overriding supports() from HandlerService. Since we are still pre-1.0.0, we can change the API freely, but bump the version to 0.2.0-SNAPSHOT to reflect this API change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes batch processing extensible by allowing plugins implementing the
BatchInputProviderinterface to support custom script parameter inputs, such asnet.imagej.Datasetwhich will be provided in theimagej-plugins-batchproject.Because
BatchServicenow extendsHandlerService, I needed to rename thesupports()methods more concisely intosupportsModule()andsupportsItem(), to avoid overridingsupports()fromHandlerService.Since we are still pre-1.0.0, we can change the API freely, but bump the version to
0.2.0-SNAPSHOTto reflect this API change.