10000 spin 0.9 update causes AttributeError in numpy CI · Issue #193 · scientific-python/spin · GitHub
[go: up one dir, main page]
Skip to content

spin 0.9 update causes AttributeError in numpy CI #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ngoldbaum opened this issue May 14, 2024 · 4 comments · Fixed by #194
Closed

spin 0.9 update causes AttributeError in numpy CI #193

ngoldbaum opened this issue May 14, 2024 · 4 comments · Fixed by #194

Comments

@ngoldbaum
Copy link
Contributor

It looks like this broke one of the numpy CI jobs: https://github.com/numpy/numpy/actions/runs/9087080853/job/24974107681?pr=26436

Error: 'types.SimpleNamespace' object has no attribute 'dir_info'; aborting.

And indeed there's a new access of a dir_info attribute added in #155.

Clues about how to fix this in the numpy CI would be appreciated if this isn't a spin bug.
@ngoldbaum ngoldbaum mentioned this issue May 14, 2024
Merged
@stefanv
Copy link
Member
stefanv commented May 14, 2024

I can replicate with a conda install.

stefanv added a commit to stefanv/spin that referenced this issue May 14, 2024
@stefanv
dir_info metadata field does not exist for conda installs
73284d6 
Closes scientific-python#193
@stefanv stefanv mentioned this issue May 14, 2024
Merged
@ngoldbaum ngoldbaum mentioned this issue May 15, 2024
Merged
stefanv added a commit that referenced this issue May 16, 2024
@stefanv
dir_info metadata field does not exist for conda installs (#194)
50f3cc6 
Closes #193
@asmeurer
Copy link

This error breaks numpy builds in a particularly confusing way. It doesn't help that Googling the error message doesn't lead to this issue for some reason (I guess Google doesn't actually index the web anymore).

Is it possible for spin to output a traceback in cases like this? Perhaps whatever code is hiding the tracebacks could try to detect if the error is a spin internal error and unhide it in that case.

To be clear if anyone does manage to find this issue, downgrading to spin=0.8 fixes the issue.

@stefanv
Copy link
Member
stefanv commented May 22, 2024

Thanks, Aaron, I think that'd be a good feature to add.

NumPy CI is pinned to the hash which works, but we should get 0.9.1 out the door.

@stefanv stefanv mentioned this issue May 22, 2024
Closed
@stefanv
Copy link
Member
stefanv commented May 22, 2024 •
edited
Loading

See PR #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dir_info metadata field does not exist for conda installs stefanv/spin
3 participants
@stefanv @asmeurer @ngoldbaum
0