Draft: Add support for some "essential" external features in targetPureWasm. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This loader file does not expose any of the JS interop features. This way, we can use the standard `run` (and later `test`) sbt commands, while verifying that are indeed not touching any JS. Moreover, the build sets up the most limited flags for Node.js based on the linker config, so we also don't have to take care of that while testing.
Like in an explicit `toString()` call dispatch, we must handle hijacked values in string concatenation with something that is an ancestor of hijacked classes.
Namely: `print`, `nanoTime`, `currentTimeMillis` and `random`. TODO: This won't work in the component model, as it requires four dedicated imports. Needs fixing before it can be merged.
|
Let me close for #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely:
print,nanoTime,currentTimeMillisandrandom.TODO: This won't work in the component model, as it requires four
dedicated imports. Needs fixing before it can be merged.
Draft PR for getting the CI to run on the rest.