8000 Fix string concat with `Any` that happens to be a hijacked value. by sjrd · Pull Request #37 · scala-wasm/scala-wasm · GitHub
[go: up one dir, main page]

Skip to content

Fix string concat with Any that happens to be a hijacked value. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sjrd
Copy link
Collaborator
@sjrd sjrd commented Apr 30, 2025

Like in an explicit toString() call dispatch, we must handle hijacked values in string concatenation with something that is an ancestor of hijacked classes.

Like in an explicit `toString()` call dispatch, we must handle
hijacked values in string concatenation with something that is an
ancestor of hijacked classes.
@sjrd sjrd requested a review from tanishiking April 30, 2025 15:46
Copy link
@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I'll enable some tests in another PR that fixed by this change :)

@tanishiking tanishiking merged commit 71128ce into scala-wasm:scala-wasm May 2, 2025
8 checks passed
@sjrd sjrd deleted the fix-string-concat-hijacked-value branch May 2, 2025 02:43
tanishiking added a commit that referenced this pull request May 2, 2025
tanishiking added a commit that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0