Report JS tree in targetPureWasm=true in Analyzer #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Apr 16, 2025
| FloatingPointBits.longBitsToDouble(bits) | ||
| linkTimeIf(LinkingInfo.targetPureWasm) { | ||
| // TODO: implement for Wasm without intrinsic? | ||
| throw new AssertionError("Not implemented.") |
There was a problem hiding this comment.
You could use (a copy of) the "polyfills" in FloatingPointBits for the 4 floating point bits conversions.
Comment on lines
227
to
228
| // TODO: implement for Wasm without intrinsic? | ||
| throw new AssertionError("Not implemented.") |
There was a problem hiding this comment.
Suggested change
| // TODO: implement for Wasm without intrinsic? | |
| throw new AssertionError("Not implemented.") | |
| (toUnsignedLong(dividend) / toUnsignedLong(divisor)).toInt |
Comment on lines
237
to
238
| // TODO: implement for Wasm without intrinsic? | ||
| throw new AssertionError("Not implemented.") |
There was a problem hiding this comment.
Suggested change
| // TODO: implement for Wasm without intrinsic? | |
| throw new AssertionError("Not implemented.") | |
| (toUnsignedLong(dividend) % toUnsignedLong(divisor)).toInt |
Comment on lines
294
to
295
| // TODO: implement for Wasm without intrinsic? | ||
| throw new AssertionError("Not implemented.") |
There was a problem hiding this comment.
You can use the algorithm under "See Hacker's Delight" from clz32Dynamic just below.
Comment on lines
40
to
42
| linkTimeIf(!LinkingInfo.targetPureWasm) { | ||
| if (writableStackTrace) | ||
| fillInStackTrace() |
There was a problem hiding this comment.
Consider moving this test inside fillInStackTrace() instead. User code can call fillInStackTrace; it should link IMO.
There was a problem hiding this comment.
Comment on lines
54
to
56
| def equals(x: Object, y: Object): Boolean = | ||
| if (scala.scalajs.LinkingInfo.targetPureWasm) { | ||
| linkTimeIf(LinkingInfo.targetPureWasm) { | ||
| equals2(x, y) |
There was a problem hiding this comment.
This one should be
if (x eq y) true
else equals2(x, y)for pure Wasm.
There was a problem hiding this comment.
528f905 to
ae95e4a
Compare
ae95e4a to
16522a3
Compare
Previously, when `targetPureWasm = true`, JS-related trees would lead to link failure at `FunctionEmitter` with an exception. However, this report only indicated which location contained the JS interop, and not the call path leading to it. This made it difficult to tell how the JS interop code was reached. This commit introduces a new `JSInteropInPureWasm` error that specifically flags JS-related trees discovered within a reachable code path when `targetPureWasm` is enabled. Now, if the Analyzer detects JS interop under these conditions, it reports not just the location but also the sequence of calls that led to that point, that improves the debugging experience for pure Wasm targets. e.g. ``` [error] Uses JS interop with targetPureWasm = true [error] dispatched from scala.collection.mutable.ArrayBuilder$.scala$collection$mutable$ArrayBuilder$$genericArrayBuilderResult(java.lang.Class,scala.scalajs.js.Array)java.lang.Object [error] called from scala.collection.mutable.ArrayBuilder$generic.result()java.lang.Object [error] dispatched from scala.collection.mutable.Builder.result()java.lang.Object [error] called from scala.collection.generic.GenericCompanion.apply(scala.collection.Seq)scala.collection.GenTraversable [error] dispatched from scala.collection.immutable.Set$.apply(scala.collection.Seq)scala.collection.GenTraversable [error] called from org.scalajs.testsuite.javalib.lang.ThrowablesTest.suppression()void [error] called from testSuiteWASI.JavalibLangTest$.run()void [error] called from testSuiteWASI.Run$.main([java.lang.String)void [error] called from static testSuiteWASI.Run.main([java.lang.String)void [error] called from core module module initializers [error] involving instantiated classes: [error] scala.collection.mutable.ArrayBuilder$generic [error] scala.collection.mutable.HashSet$ [error] scala.collection.Seq$ [error] scala.collection.immutable.Set$ [error] org.scalajs.testsuite.javalib.lang.ThrowablesTest [error] testSuiteWASI.JavalibLangTest$ [error] testSuiteWASI.Run$ ```
16522a3 to
6c8be06
Compare
sjrd
reviewed
May 25, 2025
| @inline def abs(a: scala.Double): scala.Double = js.Math.abs(a) | ||
| @inline def abs(a: scala.Float): scala.Float = | ||
| linkTimeIf(LinkingInfo.targetPureWasm) { | ||
| if (a == -0.0) 0.0f |
There was a problem hiding this comment.
I've got a better one:
Float.intBitsToFloat(Float.floatToIntBits(a) & ~Int.MinValue)😁
There was a problem hiding this comment.
Aha right, masking all bits except the sign bit turns into abs, nice 😄
Is there any reason to use ~Int.MinValue rather than Int.MaxValue ?
There was a problem hiding this comment.
MinValue is synonymous of SignBit. So it's clear that we're masking off the sign bit.
With MaxValue it's less obvious.
|
|
||
| @inline def abs(a: scala.Double): scala.Double = | ||
| linkTimeIf(LinkingInfo.targetPureWasm) { | ||
| if (a == -0.0) 0.0 |
There was a problem hiding this comment.
And likewise here:
Double.longBitsToDouble(Double.doubleToLongBits(a) & ~Long.MinValue)To avoid analyzer reports the `JSInteropInPureWasm` error
6c8be06 to
eeb00ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picking scala-js@95d74bfPreviously, when
targetPureWasm = true, JS-related treeswould lead to link failure at
FunctionEmitterwith an exception.However, this report only indicated which location contained the JS interop, and not the call path leading to it.
This made it difficult to tell how the JS interop code was reached.
This commit introduces a new
JSInteropInPureWasmerror that specifically flags JS-related trees discovered within a reachable code path whentargetPureWasmis enabled.Now, if the Analyzer detects JS interop under these conditions, it reports not just the location but also the sequence of calls that led to that point, that improves the debugging experience for pure Wasm targets.