{{ message }}
Switch to GitHub Actions for the Windows CI. #5174
Merged
+51
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
approved these changes
May 19, 2025
| apps: sbt | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '24.x' |
There was a problem hiding this comment.
Is there a reason we are upgrading node with this change?
There was a problem hiding this comment.
The reason is "why not, while we're here?". The LInux CI currently uses 23.x (we upgraded for the Wasm support) but we should also upgrade it to 24 relatively soon.
.github/workflows/windows-ci.yml
Outdated
| git config --global core.eol lf | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| # fetch the Git tags for sbt-dynver and sbt-version-policy to work correctly |
There was a problem hiding this comment.
Hum, we are not using these, are we?
There was a problem hiding this comment.
Oops, indeed. Copy-pasta from another repo where they are actually used.
| matrix: | ||
| java: [ '8' ] | ||
|
|
||
| runs-on: windows-latest |
There was a problem hiding this comment.
You are the windows guru: I guess we'll be less affected by ambient changes due to the lack of pinning then by breakages because of changing version support?
AppVeyor has become increasingly unstable recently. While we're there, upgrade to Node.js 24.x.
1954a2b to
7516f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated sugge
2D9D
stions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppVeyor has become increasingly unstable recently.