8000 Actually delete temp files created by partest for Wasm. by sjrd · Pull Request #5153 · scala-js/scala-js · GitHub
[go: up one dir, main page]
Skip to content

Actually delete temp files created by partest for Wasm. #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Actually delete temp files created by partest for Wasm. #5153

merged 1 commit into from
Apr 5, 2025

Conversation

sjrd
Copy link
Member
@sjrd sjrd commented Apr 1, 2025

It turns out deleteOnExit() does not do anything for non-empty directories. So we must recursively delete our temporary output directory ourselves.

/cc @fsalvi

@sjrd
Actually delete temp files created by partest for Wasm.
67fa195 
It turns out `deleteOnExit()` does not do anything for non-empty
directories. So we must recursively delete our temporary output
directory ourselves.
@sjrd sjrd requested a review from gzm0 April 1, 2025 14:41
@gzm0 gzm0 merged commit 7a2cf72 into scala-js:main Apr 5, 2025
3 checks passed
@som-snytt
Copy link
Contributor

Releasable for Using at https://github.com/scala/scala/blob/2.13.x/src/testkit/scala/tools/testkit/TempDir.scala#L48

@sjrd sjrd deleted the partest-actually-delete-temp-dirs branch April 5, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzm0 gzm0 gzm0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjrd @som-snytt @gzm0
0