8000 Printer improvements to fuse JS emitting and printing by gzm0 · Pull Request #4920 · scala-js/scala-js · GitHub
[go: up one dir, main page]
Skip to content

Printer improvements to fuse JS emitting and printing #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 28, 2024
Merged

Printer improvements to fuse JS emitting and printing #4920

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e55b624
Basic tests for javascript.Printers
gzm0 Dec 28, 2023
c2ed2bb
Print semicolon as part of statement in javascript Printer
gzm0 Dec 25, 2023
197af9a
Do not print skip's in blocks
gzm0 Dec 28, 2023
7c3797d
Do not abuse a block to group instance tests
gzm0 Dec 28, 2023
bdea4d7
Do not abuse a block to group const field export statements
gzm0 Dec 29, 2023
135932a
Simplify printTopLevelTree in JS printer
gzm0 Dec 28, 2023
de0d65c
Restrict visibility of JS Printer methods
gzm0 Dec 29, 2023
bd58bbb
Print trailing newline as part of statement
gzm0 Dec 29, 2023
cae909a
Remove printTopLevelTree and replace it with printStat
gzm0 Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify printTopLevelTree in JS printer 
Because it does not need to flatten blocks anymore, we can simply
print it as a statement and add a trailing newline.
  • Loading branch information
@gzm0
gzm0 committed Jan 28, 2024
commit 135932afa2601f9f2b914c1fdea806f4d3903c25
15 changes: 2 additions & 13 deletions linker/shared/src/main/scala/org/scalajs/linker/backend/javascript/Printers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,19 +62,8 @@ object Printers {
}

def printTopLevelTree(tree: Tree): Unit = {
tree match {
case Skip() =>
// do not print anything
case tree: Block =>
var rest = tree.stats
while (rest.nonEmpty) {
printTopLevelTree(rest.head)
rest = rest.tail
}
case _ =>
printStat(tree)
println()
}
printStat(tree)
println()
}

protected def printRow(ts: List[Tree], start: Char, end: Char): Unit = {
Expand Down
0