Intern unscoped global field name strings #4910
Conversation
Memory profile analysis shows ~120k duplicates of the string "$n" amounting to ~6MB waste (on the test suite). Further digging revealed that this happens through the "$n" call-helper (null check) via: - SJSGen#genCallHelper - VarGen#globalVar - VarGen#globalVarIdent - VarGen#genericIdent A more invasive (but efficient) alternative would be to move the prefix to the call sites. As a result, no runtime interning would have to be performed as the strings would end up being part ot the static constant pool. Discovered while working on scala-js#4906.
|
@sjrd WYDT? I've been toying with the idea of having all the fields in VarGen (maybe even in an |
|
Common wisdom goes against the use of the global
This seems like a much better alternative, indeed. |
|
Closing in favor of #4911. |
Memory profile analysis shows ~120k duplicates of the string "$n" amounting to ~6MB waste (on the test suite).
Further digging revealed that this happens through the "$n" call-helper (null check) via:
A more invasive (but efficient) alternative would be to move the prefix to the call sites. As a result, no runtime interning would have to be performed as the strings would end up being part ot the static constant pool.
Discovered while working on #4906.